fix: remove Slider from the global export #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmfrancois
commented
Dec 22, 2017
| @@ -3,7 +3,7 @@ import React from 'react'; | |||
|
|
|||
| import RJSForm from 'react-jsonschema-form/lib/index'; | |||
|
|
|||
| import { Action } from '@talend/react-components'; | |||
| import Action from '@talend/react-components/lib/Actions/Action'; | |||
There was a problem hiding this comment.
this one is weird, we should put Action at the root (I think)
romainseb
requested review from
romainseb
and removed request for
talend-sromain
romainseb
approved these changes
Dec 22, 2017
jsomsanith-tlnd
suggested changes
Dec 22, 2017
jsomsanith-tlnd
approved these changes
Dec 26, 2017
jsomsanith-tlnd
deleted the
jmfrancois/fix/forms/remove-the-need-of-slider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
Each time we add a new component with a dependency it becomes hard for every one to update.
Think to add this deps into the project.
It's also embed in the build because all components are exposed by the global index.js.
This is the case with rc-slider.
What is the chosen solution to this problem?
Let's remove Slider from index.js (breaking change)
This will be done for every components so we will decrease our bundle size.
The main idea is to import component from it's folder when it's possible.
Here we have update forms package to do so.
Please check if the PR fulfills these requirements
[ ] This PR introduces a breaking change