chore: improve composition #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmfrancois
commented
Apr 27, 2017
| @@ -49,6 +54,9 @@ const actionPropTypes = PropTypes.oneOfType([ | |||
| }), | |||
| ]); | |||
|
|
|||
| Object.keys(Component).forEach((key) => { | |||
| ActionBar[key] = Component[key]; | |||
| }); | |||
There was a problem hiding this comment.
This is to keep the attached stuff:
Container's ActionBar.SwitchActions , etc ...
…lend/ui into jmfrancois/improve-composition-action
1 similar comment
talend-sromain
approved these changes
Apr 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
guidelines
What is the current behavior? (You can also link to an open issue here)
If I'm using container ActionsBar it render pure component ActionsBar which render pure Action / Actions or ActionSplitDropdown.
I have no option to use container Action / Actions so I have to re-implement the connection.
What is the new behavior?
The component ActionsBar support for a renderers props which is a mapping of subcomponent used.
The container ActionsBar inject this props with the connected version
https://github.com/Talend/ui/wiki/CMF---Container---Components-guidelines