-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ARCH-345): update all redux related packages #3027
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
1 similar comment
1 similar comment
1 similar comment
Size Change: -247 kB (-2%) Total Size: 15 MB
ℹ️ View Unchanged
|
Size Change: -247 kB (-2%) Total Size: 15 MB
ℹ️ View Unchanged
|
Size Change: -247 kB (-2%) Total Size: 15 MB
ℹ️ View Unchanged
|
Size Change: -246 kB (-2%) Total Size: 15 MB
ℹ️ View Unchanged
|
Size Change: -246 kB (-2%) Total Size: 15 MB
ℹ️ View Unchanged
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
Our redux stack is very old... and redux upgrade need other upgrades
Some libs like react-dnd depends on last redux version so we have redux twice.
What is the chosen solution to this problem?
So yes you can t use multiple contextTypes as for now. So all components using this must be re written as function and can use useCMFContext to access a context object.
Please check if the PR fulfills these requirements
[*] This PR introduces a breaking change
redux: 3.x -> 4.x
redux-saga: 0.1 -> 1.0
Please look at this wiki page for information on it.
https://github.com/Talend/ui/wiki/UI-7-Breaking-changes