chore(cmf): simplify imports #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmfrancois
commented
May 21, 2018
| 'getCollection', | ||
| 'dispatch', | ||
| 'dispatchActionCreator', | ||
| ]; |
There was a problem hiding this comment.
moved in constant
jmfrancois
changed the title
1 similar comment
…/ui into jmfrancois/chore/cmf-api-to-index
acateland
suggested changes
May 24, 2018
docs/_posts/2017-02-28-api-action.md
Outdated
| @@ -80,11 +81,11 @@ api.action.getOnProps(props); | |||
|
|
|||
| It returns the array of props keys beginning with `on`. This is used to get the list of action props (onClick, onKeyDown, ...). | |||
|
|
|||
| ## mapDispatchToProps | |||
| ## mapDispatchToProps (DEPRECATED) | |||
There was a problem hiding this comment.
if deprecated please remove doc to avoid people to keep using it
docs/_posts/2017-02-28-api-action.md
Outdated
| @@ -67,11 +68,11 @@ It creates the action to dispatch from | |||
| * the provided user `event` | |||
| * the provided user `data` | |||
|
|
|||
| ## getOnProps | |||
| ## getOnProps (DEPRECATED) | |||
There was a problem hiding this comment.
if deprecated please remove doc to avoid people to keep using it
docs/_posts/2017-02-28-api-action.md
Outdated
| @@ -47,11 +48,11 @@ api.action.getActionInfo(context, id); | |||
|
|
|||
| It returns the static `action` definition from the settings. | |||
|
|
|||
| ## getActionObject | |||
| ## getActionObject (DEPRECATED) | |||
There was a problem hiding this comment.
if deprecated please remove doc to avoid people to keep using it
docs/_posts/2017-02-28-api-action.md
Outdated
| @@ -33,11 +34,11 @@ api.actionCreator.get(context, id); | |||
|
|
|||
| It returns the registered `action creator` from the provided registry. | |||
|
|
|||
| ## getActionInfo | |||
| ## getActionInfo (DEPRECATED) | |||
There was a problem hiding this comment.
if deprecated please remove doc to avoid people to keep using it
docs/_posts/2017-02-28-api-action.md
Outdated
| @@ -6,11 +6,12 @@ date: 2017-02-28 22:10:38 | |||
| order: 3 | |||
| --- | |||
|
|
|||
| ## getActionsById | |||
| ## getActionsById (DEPRECATED) | |||
There was a problem hiding this comment.
if deprecated please remove doc to avoid people to keep using it
…/ui into jmfrancois/chore/cmf-api-to-index
acateland
approved these changes
May 25, 2018
romainseb
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
having api create more troubles than it solves anything.
The first idea of { api } was to expose only what the developer needs.
We are in progress to make cmf a framework and so we need to make import simple and easy to understand.
What is the chosen solution to this problem?
So no more { api } just index, so all the things are accessible from index and more and more we will remove all deprecated stuff in the following PRs.
Let's introduce the default export 'cmf':
This will replace { api } and provide more and less stuff;
the next step is #1293 (bootstrap)
Please check if the PR fulfills these requirements
[ ] This PR introduces a breaking change