fix(forms): switch to UIform if uischema is an array #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
jsomsanith-tlnd
suggested changes
Apr 19, 2018
| @@ -44,7 +44,7 @@ export default class UIForm extends React.Component { | |||
| if (!this.props.onChange) { | |||
| return; | |||
| } else if (this.props.moz) { | |||
| this.props.onChange(payload); | |||
| this.props.onChange(null, payload); | |||
There was a problem hiding this comment.
Here you have the event (which can be null), just pass it.
With that you can even remove this if/elseif/else by
if (this.props.onChange) {
this.props.onChange(event, payload);
}
packages/forms/src/Form.js
Outdated
| @@ -132,6 +132,9 @@ class Form extends React.Component { | |||
| } | |||
| return <UIForm {...props} />; | |||
| } | |||
| if (Array.isArray(this.props.data.uiSchema)) { | |||
There was a problem hiding this comment.
Not a big deal, but isn't that the most determinant condition ? If so it should be the first test in the render method.
- if it's uiSpec v1 --> render directly the UIForm with all the props
- if we have the uiForm flag, it means that we have uiSpec v0 but we want to use UIForm --> widget adaptation and render UIForm
- else render RJSFForm
packages/forms/src/Form.test.js
Outdated
| @@ -373,3 +375,17 @@ describe('<Form/>', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('<UIForm/>', () => { | |||
There was a problem hiding this comment.
No need for another describe because you're still testing <Form>. Please move the test in the previous describe.
packages/forms/src/Form.test.js
Outdated
| props = initProps(); | ||
| }); | ||
|
|
||
| it('should render uiform', () => { |
There was a problem hiding this comment.
should render UIForm with uiSchema array format ?
…//github.com/Talend/ui into jmfrancois/fix/forms/better-switch-to-uiform
rmannibucau
approved these changes
Apr 19, 2018
jsomsanith-tlnd
suggested changes
Apr 23, 2018
| const props = initProps(); | ||
| // when | ||
| wrapper = shallow(<Form data={dataUIForm} {...props} />); | ||
| expect(wrapper.getElement()).toMatchSnapshot(); |
There was a problem hiding this comment.
The shallow snapshot doesn't check that we have a UIForm.
- Don't forget to check the snapshot when you write/modify one
- Here you can check that without snapshot (which will log a lot more info than what you want to test)
There was a problem hiding this comment.
My bad I will learn to read
jsomsanith-tlnd
approved these changes
Apr 23, 2018
jsomsanith-tlnd
deleted the
jmfrancois/fix/forms/better-switch-to-uiform
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
What is the chosen solution to this problem?
props.onChange(...args)props.onChange(null, ...args)props.onSubmit(changes)props.onSubmit(null, changes)This last change can impact projects using directly the component Form.js
To summarize : Now we can have three cases with usage of Form container
Please check if the PR fulfills these requirements
[ ] This PR introduces a breaking change