fix(components/typeahead): use a flag for the display mode #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g_for_the_display_mode
frassinier
suggested changes
Feb 26, 2018
| function Typeahead({ onToggle, icon, position, ...rest }) { | ||
| if (onToggle) { | ||
| function Typeahead({ onToggle, icon, position, docked, ...rest }) { | ||
| if (docked === true && onToggle) { |
There was a problem hiding this comment.
if (!!docked && onToggle)
| const wrapper = renderer | ||
| .create(<Typeahead {...props} />) | ||
| .toJSON(); | ||
| const wrapper = renderer.create(<Typeahead {...props} />).toJSON(); |
There was a problem hiding this comment.
Why would you want to see it modified by this test ?
added 2 commits
February 27, 2018 11:30
…g_for_the_display_mode
frassinier
approved these changes
Feb 27, 2018
| const wrapper = renderer | ||
| .create(<Typeahead {...props} />) | ||
| .toJSON(); | ||
| const wrapper = renderer.create(<Typeahead {...props} />).toJSON(); |
…g_for_the_display_mode
…g_for_the_display_mode
jsomsanith-tlnd
approved these changes
Feb 28, 2018
jsomsanith-tlnd
deleted the
ncomont/fix/components/typeahead/use_a_flag_for_the_display_mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
The only way to display the typeahead input when using the toggle functionnality is to delete the
onToggleproperty, which is obviously a bad thing.What is the chosen solution to this problem?
Add a
dockedproperty.Please check if the PR fulfills these requirements
[x] This PR introduces a breaking change