Updated code for node v4 compilation #1
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hulbert
Compiles on node v4.2.2.
Build instructions:
Major steps used to convert to node v4:
MaybeLocal
instead ofLocal
(which is kind of an optional -- see https://github.com/nodejs/nan/blob/master/doc/maybe_types.md#api_nan_maybe_local), force converted them toLocal
withToLocalChecked()
(unsafe).args
was renamed toinfo