[TASK] Configure frontend caches with NullBackend #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit configures the frontend related caches to use the NullBackend, which avoids creating corresponding tables and reduces SELECT and INSERT database statements. However, some core tests specificly tests against these tables needs to specify the database backend again to avoid test failing tests.
sbuerk
added a commit
that referenced
this pull request
May 28, 2023
The patch configures frontend related caches to ese the NullBackend in functional tests. This avoids creating corresponding tables and reduces SELECT and INSERT database statements. This results in a performance increase running frontend functional tests, with core, this is around 5-10% when using postgres DMBS.
sbuerk
added a commit
that referenced
this pull request
May 28, 2023
The patch configures frontend related caches to ese the NullBackend in functional tests. This avoids creating corresponding tables and reduces SELECT and INSERT database statements. This results in a performance increase running frontend functional tests, with core, this is around 5-10% when using postgres DMBS.
sbuerk
added a commit
that referenced
this pull request
Jun 25, 2023
The patch configures frontend related caches to ese the NullBackend in functional tests. This avoids creating corresponding tables and reduces SELECT and INSERT database statements. This results in a performance increase running frontend functional tests, with core, this is around 5-10% when using postgres DMBS. `extbase_object` cache has been removed with TYPO3 v10, therefore no longer set it to a `NullBackend`. The extbase caches has been mergend. Setting the cache to NullBackend does not have a benefit for core testing. If a extension would benefit from it, they can provide it by themself as a configuration override.
sbuerk
added a commit
that referenced
this pull request
Jun 25, 2023
The patch configures frontend related caches to ese the NullBackend in functional tests. This avoids creating corresponding tables and reduces SELECT and INSERT database statements. This results in a performance increase running frontend functional tests, with core, this is around 5-10% when using postgres DMBS. `extbase_object` cache has been removed with TYPO3 v10, therefore no longer set it to a `NullBackend`. The extbase caches has been mergend. Setting the cache to NullBackend does not have a benefit for core testing. If a extension would benefit from it, they can provide it by themself as a configuration override.
sbuerk
added a commit
that referenced
this pull request
Jun 27, 2023
The patch configures frontend related caches to ese the NullBackend in functional tests. This avoids creating corresponding tables and reduces SELECT and INSERT database statements. This results in a performance increase running frontend functional tests, with core, this is around 5-10% when using postgres DMBS. `extbase_object` cache has been removed with TYPO3 v10, therefore no longer set it to a `NullBackend`. The extbase caches has been mergend. Setting the cache to NullBackend does not have a benefit for core testing. If a extension would benefit from it, they can provide it by themself as a configuration override.
sbuerk
added a commit
that referenced
this pull request
Jun 27, 2023
The patch configures frontend related caches to ese the NullBackend in functional tests. This avoids creating corresponding tables and reduces SELECT and INSERT database statements. This results in a performance increase running frontend functional tests, with core, this is around 5-10% when using postgres DMBS. `extbase_object` cache has been removed with TYPO3 v10, therefore no longer set it to a `NullBackend`. The extbase caches has been mergend. Setting the cache to NullBackend does not have a benefit for core testing. If a extension would benefit from it, they can provide it by themself as a configuration override.
sbuerk
added a commit
that referenced
this pull request
Aug 2, 2023
This reverts commit c32fe20. Setting some cache configurations to NullBackend needs adoption in core tests. Therefore, the backport to set the new caches to NulLBackend is reverted. The removed non-existing `extbase_object` NullBackend configuration stays removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit configures the frontend related caches to
use the NullBackend, which avoids creating corresponding
tables and reduces SELECT and INSERT database statements.
However, some core tests specificly tests against these
tables needs to specify the database backend again to
avoid test failing tests.
Configuration preparation has been prepared as core patch:
72706: [TASK] Use database cache backend for specific tests
https://review.typo3.org/c/Packages/TYPO3.CMS/+/72706
Merging this pull-request should be done with raising the
testing-framework hash in that patch and merging the core
patch shortly after the merge into the testing-framework
to avoid failing nightlies with composerInstallMax tests.