Do not enable redirects.hitCount feature by default in acceptance tests
#554
Comments
sbuerk
added a commit
that referenced
this issue
Nov 29, 2024
This change removes the enabling of feature `redirects.hitCount` within codeception acceptance test setups to stay on TYPO3 Core defaults. That has been preared with temporary solution for TYPO3 Core tests [1]. * [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/87280 Resolves: #554 Releases: main
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this issue
Nov 29, 2024
Composer mode acceptance tests has been introduced with #103297, including a conditional check for the `redirects.hitCount` based on the environment (classic or composer mode) required due to the fact that typo3/testing-framework sets this toggle to `true`. Valid request has been made to remove the toggle setting from the typo3/testing-framework setup [1]. This change removes the codeception conditional based checkbox check and resets the `redirects.hitCount` toggle to the default value as a temporary solution. After removing enabling this toggle in the testing-framework and relasing this, the temporary solution can be removed again. [1] TYPO3/testing-framework#554 Resolves: #105725 Related: #103297 Releases: main, 13.4 Change-Id: I610951d211ead78cd17567a4dde9f9d6d98ae7d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87281 Tested-by: core-ci <typo3@b13.com> Tested-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Stefan Bürk <stefan@buerk.tech>
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this issue
Nov 29, 2024
Composer mode acceptance tests has been introduced with #103297, including a conditional check for the `redirects.hitCount` based on the environment (classic or composer mode) required due to the fact that typo3/testing-framework sets this toggle to `true`. Valid request has been made to remove the toggle setting from the typo3/testing-framework setup [1]. This change removes the codeception conditional based checkbox check and resets the `redirects.hitCount` toggle to the default value as a temporary solution. After removing enabling this toggle in the testing-framework and relasing this, the temporary solution can be removed again. [1] TYPO3/testing-framework#554 Resolves: #105725 Related: #103297 Releases: main, 13.4 Change-Id: I610951d211ead78cd17567a4dde9f9d6d98ae7d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87280 Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Garvin Hicking <gh@faktor-e.de> Reviewed-by: Stefan Bürk <stefan@buerk.tech> Tested-by: core-ci <typo3@b13.com> Tested-by: Garvin Hicking <gh@faktor-e.de>
sbuerk
added a commit
that referenced
this issue
Nov 29, 2024
This change removes the enabling of feature `redirects.hitCount` within codeception acceptance test setups to stay on TYPO3 Core defaults. That has been preared with temporary solution for TYPO3 Core tests [1]. * [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/87280 Resolves: #554 Releases: main
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/core
that referenced
this issue
Nov 29, 2024
Composer mode acceptance tests has been introduced with #103297, including a conditional check for the `redirects.hitCount` based on the environment (classic or composer mode) required due to the fact that typo3/testing-framework sets this toggle to `true`. Valid request has been made to remove the toggle setting from the typo3/testing-framework setup [1]. This change removes the codeception conditional based checkbox check and resets the `redirects.hitCount` toggle to the default value as a temporary solution. After removing enabling this toggle in the testing-framework and relasing this, the temporary solution can be removed again. [1] TYPO3/testing-framework#554 Resolves: #105725 Related: #103297 Releases: main, 13.4 Change-Id: I610951d211ead78cd17567a4dde9f9d6d98ae7d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87280 Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Garvin Hicking <gh@faktor-e.de> Reviewed-by: Stefan Bürk <stefan@buerk.tech> Tested-by: core-ci <typo3@b13.com> Tested-by: Garvin Hicking <gh@faktor-e.de>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/core
that referenced
this issue
Nov 29, 2024
Composer mode acceptance tests has been introduced with #103297, including a conditional check for the `redirects.hitCount` based on the environment (classic or composer mode) required due to the fact that typo3/testing-framework sets this toggle to `true`. Valid request has been made to remove the toggle setting from the typo3/testing-framework setup [1]. This change removes the codeception conditional based checkbox check and resets the `redirects.hitCount` toggle to the default value as a temporary solution. After removing enabling this toggle in the testing-framework and relasing this, the temporary solution can be removed again. [1] TYPO3/testing-framework#554 Resolves: #105725 Related: #103297 Releases: main, 13.4 Change-Id: I610951d211ead78cd17567a4dde9f9d6d98ae7d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87281 Tested-by: core-ci <typo3@b13.com> Tested-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What are you trying to achieve?
The feature
redirects.hitCountshould not be enabled by default in acceptance test instances, in order to avoid unexpected default that derive from a regular installations.Additional information you would like to provide?
Related: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83027/25#message-5385a3697a49c0686cecedfccf8c665477069cbf
The text was updated successfully, but these errors were encountered: