[FIX] Import custom GalleryProcessor instead of processor from fluid_… #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…styled_content I get the following error in TYPO3 v12: #1427455378 UnexpectedValueException Processor class or service name "gallery" does not exist! This has to do with fluid_styled_content now using identifiers for setting the DataProcessors inside the TypoScript configuration and not the full class name anymore. The origin of this error seems to be that in your Services.php you register "headless-gallery" as an identifier for "TYPO3\CMS\Frontend\DataProcessing\GalleryProcessor" and not for your custom DataProcessor "FriendsOfTYPO3\Headless\DataProcessing\GalleryProcessor" so the identifier is overridden and the DataProcessing of the regular images stops working.
Pull Request Test Coverage Report for Build 5666584125
💛 - Coveralls |
|
@parallaxis-mcgoldrick could you check php-cs-fixer and fix your files based on those requirements? |
twoldanski
approved these changes
Jul 26, 2023
lukaszuznanski
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…styled_content
I get the following error in TYPO3 v12:
This has to do with fluid_styled_content now using identifiers for setting the DataProcessors inside the TypoScript configuration and not the full class name anymore.
The origin of this error seems to be that in your Services.php you register "headless-gallery" as an identifier for "TYPO3\CMS\Frontend\DataProcessing\GalleryProcessor" and not for your custom DataProcessor "FriendsOfTYPO3\Headless\DataProcessing\GalleryProcessor" so the identifier is overridden and the DataProcessing of the regular images stops working.