Skip to content

Commit

Permalink
[BUGFIX] Update doctrine/dbal to ensure performance bugfix
Browse files Browse the repository at this point in the history
Doctrine DBAL 3.7.0 introduced a performance issue [1]
which has been already fixed by the Doctrine Team [2].

This change updates the `doctrine/dbal` composer constraint
to ensure that this performance issue is gone.

Note:   The monorepo composer.lock already containted the
        3.7.2 bugfis release, therefore this has not been
        detected in casual core development. This update
        is to mitigate the performance issue at all costs
        for TYPO3 users.

As a sideeffect, this should put `composerInstallMin`
nightly function tests on speed again.

Used command(s):

> composer require --no-update --no-install \
    -d typo3/sysext/redirects \
    "doctrine/dbal":"^3.7.2" ; \
  composer require --no-update --no-install \
    -d typo3/sysext/core \
    "doctrine/dbal":"^3.7.2" ; \
  composer require --no-update --no-install \
    -d typo3/sysext/install \
    "doctrine/dbal":"^3.7.2" ; \
  composer require --no-update \
    "doctrine/dbal":"^3.7.2" ; \
  composer update --lock

[1] contao/contao#6409
[2] doctrine/dbal#6202

Resolves: #102830
Releases: main, 12.4
Change-Id: If8b09f9556f11cc0fda4690f81343fc6c5d5e476
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82449
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Garvin Hicking <gh@faktor-e.de>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Garvin Hicking <gh@faktor-e.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
  • Loading branch information
sbuerk committed Jan 12, 2024
1 parent 0dd2c22 commit 7433fee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"sort-packages": true
},
"require": {
"doctrine/dbal": "^3.7.1",
"doctrine/dbal": "^3.7.2",
"psr/http-message": "^1.1 || ^2.0",
"psr/log": "^2.0 || ^3.0",
"symfony/console": "^6.4 || ^7.0",
Expand Down

0 comments on commit 7433fee

Please sign in to comment.