Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scenario suffix handling for case sensitive file systems #517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sfo
Copy link
Contributor

@sfo sfo commented Jul 25, 2024

On case-sensitive file systems, loading a scenario file with upper case .SCN extension (like provided by bluesky itself) fails with a file not found exception since the method for reading the file replaces the suffix with lower case .scn.

@jooste
Copy link
Member

jooste commented Jul 25, 2024

This might not be necessary if we go for a complete solution for case sensitive file systems, see also my comment in the IC IC PR.

@sfo
Copy link
Contributor Author

sfo commented Jul 29, 2024

In the other comment you wrote "[...] adapt the scenario loader [...]". Do you refer to the readscn method?

I just checked my fix, which fails to load scenarios without a suffix (like in the IC IC case). For these, a .sim suffix gets appended implicitly, which can fail on case-sensitive file systems. Even worse, there might be multiple possible candidate files, for instance a .SCN and a .ScN and a .sCn (even though, this is unrealistic, it could happen).

How should this be handled? Maybe just support .SCN and .scn and only fail if both or neither variant could be found on loading?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants