vgui: Reworked inheritance #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimGoll
added
the
skip-changelog
|
this is done since our custom tooltip doesn't ignore empty setters |
ZenBre4ker
approved these changes
Jan 19, 2025
gamemodes/terrortown/gamemode/client/cl_vskin/vgui/dcheckboxlabel_ttt2.lua
Show resolved
Hide resolved
Checkbox is still a gmod based element that therefore can't inherit from our code. The checkboxlabel, which includes a checkbox, inherits from our button same as role image |
Histalek
pushed a commit
to WardenPotato/TTT2
that referenced
this pull request
Jan 31, 2025
This PR adds no new code or new functionality, it only moves code around in files so that everything that inherits from buttons can use (server) convars. Therefore the code from the ttt2 checkboxlabel was moved to button. This caused this change to track the underlying button in those labels:  Moreover I added our tooltip code from the panel to the label as well, as both of these are a starting point for the inheritance that can't be merged. I'd appreaciate a quick merge so that TTT-2#1715 can be finished. Also note, that there are MANY things that could be further improved by improving the inheritance. This only tackles a small part of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds no new code or new functionality, it only moves code around in files so that everything that inherits from buttons can use (server) convars. Therefore the code from the ttt2 checkboxlabel was moved to button. This caused this change to track the underlying button in those labels:
Moreover I added our tooltip code from the panel to the label as well, as both of these are a starting point for the inheritance that can't be merged.
I'd appreaciate a quick merge so that #1715 can be finished.
Also note, that there are MANY things that could be further improved by improving the inheritance. This only tackles a small part of that.