Rolelayering: Show Role Enable Status #1715
Conversation
TimGoll
added
the
type/enhancement
|
Slowly making progress with the inheritance. But it is a bit painful |
|
Got it working. Will finish this PR once #1722 is merged |
This PR adds no new code or new functionality, it only moves code around in files so that everything that inherits from buttons can use (server) convars. Therefore the code from the ttt2 checkboxlabel was moved to button. This caused this change to track the underlying button in those labels:  Moreover I added our tooltip code from the panel to the label as well, as both of these are a starting point for the inheritance that can't be merged. I'd appreaciate a quick merge so that #1715 can be finished. Also note, that there are MANY things that could be further improved by improving the inheritance. This only tackles a small part of that.
|
@nike4613 Maybe you want to take a quick look on this as well |
|
|
I'm confused, the role icon is dimmed in the image in the OP? (yes, I updated the screenshot) |
|
I personally would prefer keeping the coloration (though with dimming/darkening/whatever) as opposed to completely removing it here. I quite like the way that the dimmed icons look over in #1714 even without the extra overlay clarifying that they're disabled. |
I tried that at first, but I didn't like it because it wasn't that clear on first glace. For your usecase I see the reason why you'd like that though. You use the role-image element to show if a role was selected or not - am I right? We should probably extend the role image then a bit. Since a gray version with a red border probably doesn't make too much sense for your use-case? I'm not sure. I'll merge this PR for now, but I'm open to add more to this for your UI. Personally, I think the design language I chose here is better for this specific use case, but not for yours. |
This PR adds no new code or new functionality, it only moves code around in files so that everything that inherits from buttons can use (server) convars. Therefore the code from the ttt2 checkboxlabel was moved to button. This caused this change to track the underlying button in those labels:  Moreover I added our tooltip code from the panel to the label as well, as both of these are a starting point for the inheritance that can't be merged. I'd appreaciate a quick merge so that TTT-2#1715 can be finished. Also note, that there are MANY things that could be further improved by improving the inheritance. This only tackles a small part of that.
Fixes TTT-2#1700 by showing the enable status of a role. Also adds the functionality to quickly enable/disable the role right from the role layering menu. Looks like this: 
Fixes #1700 by showing the enable status of a role.
Also adds the functionality to quickly enable/disable the role right from the role layering menu.
Looks like this:
