Skip to content

Commit

Permalink
Using import rather than require for date-holidays (#1126)
Browse files Browse the repository at this point in the history
  • Loading branch information
araujoarthur0 authored Jan 15, 2025
1 parent 7777f68 commit eb7ddbc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
5 changes: 1 addition & 4 deletions __tests__/__renderer__/workday-waiver.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import '../../__mocks__/jquery.mjs';

import assert from 'assert';
import Holidays from 'date-holidays';
import Store from 'electron-store';
import { JSDOM } from 'jsdom';
import sinon from 'sinon';
Expand All @@ -23,10 +24,6 @@ import {
savePreferences,
} from '../../js/user-preferences.mjs';

import { createRequire } from 'module';
const require = createRequire(import.meta.url);

const Holidays = require('date-holidays');

import { i18nTranslatorMock } from '../../renderer/i18n-translator.js';
i18nTranslatorMock.mock('translatePage', sinon.stub().returnsThis());
Expand Down
10 changes: 2 additions & 8 deletions main/workday-waiver-aux.mjs
Original file line number Diff line number Diff line change
@@ -1,19 +1,13 @@
'use strict';

// Allow require()
import { createRequire } from 'module';
const require = createRequire(import.meta.url);

import Holidays from 'date-holidays';
import { ipcMain } from 'electron';
import Store from 'electron-store';
const waiverStore = new Store({name: 'waived-workdays'});

// 'date-holidays' must be required and not imported
const Holidays = require('date-holidays');
const hd = new Holidays();
const waiverStore = new Store({name: 'waived-workdays'});

// Waiver Store handlers

function getWaiverStore()
{
return waiverStore.store;
Expand Down

0 comments on commit eb7ddbc

Please sign in to comment.