Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV capacity summary statistic #552

Merged
merged 4 commits into from
Mar 31, 2022
Merged

CV capacity summary statistic #552

merged 4 commits into from
Mar 31, 2022

Conversation

d-cogswell
Copy link
Collaborator

This adds a CV capacity summary statistic for both regular and diagnostic cycles, which is distinct from the CV time and current stats I added previously. I included a regression test.

After merging I would appreciate a re-run of structuring on AWS for PreDiag and PredictionDiagnostics data sets.

@d-cogswell d-cogswell requested a review from pkherring February 24, 2022 04:11
@ardunn ardunn requested review from ardunn and shijingsun-TRI and removed request for pkherring March 11, 2022 20:14
Copy link
Contributor

@shijingsun-TRI shijingsun-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, new functions will show up in the pipeline following the next release of the package.

@ardunn
Copy link
Collaborator

ardunn commented Mar 14, 2022

tests failed due to a coveralls error, I am rerunning all of them. once they pass we should merge

Copy link
Collaborator

@ardunn ardunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would amend the get_CV_capacity function to throw the correct exceptions when bad input is given; returning None using isinstance checking might cause silent errors down the line

beep/structure/base.py Outdated Show resolved Hide resolved
beep/structure/base.py Outdated Show resolved Hide resolved
@ardunn ardunn merged commit 445513e into master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants