Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow biologic txt files to structure #518

Merged
merged 5 commits into from
Jan 24, 2022
Merged

Allow biologic txt files to structure #518

merged 5 commits into from
Jan 24, 2022

Conversation

shijingsun-TRI
Copy link
Contributor

No description provided.

@shijingsun-TRI shijingsun-TRI marked this pull request as ready for review January 21, 2022 15:36
patrickherring-TRI
patrickherring-TRI suggested changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@patrickherring-TRI patrickherring-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you were able to resolve the issue! We should keep the existing tests so that we don't reduce functionality.

beep/structure/biologic.py Outdated Show resolved Hide resolved
beep/structure/tests/test_cyclerpaths.py Show resolved Hide resolved
@shijingsun-TRI
Copy link
Contributor Author

Looks like you were able to resolve the issue! We should keep the existing tests so that we don't reduce functionality.

Existing tests are kept and a new test is now added.

ardunn
ardunn reviewed Jan 23, 2022
View reviewed changes
beep/structure/biologic.py Outdated Show resolved Hide resolved
patrickherring-TRI
patrickherring-TRI approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@patrickherring-TRI patrickherring-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

beep/structure/biologic.py Outdated Show resolved Hide resolved
@shijingsun-TRI shijingsun-TRI merged commit a0d6fd0 into master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickherring-TRI patrickherring-TRI patrickherring-TRI approved these changes

@ardunn ardunn ardunn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shijingsun-TRI @ardunn @patrickherring-TRI