Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qmckl_compute_asymp_jasb_f to C #59

Merged
merged 13 commits into from
Feb 4, 2022
Merged

qmckl_compute_asymp_jasb_f to C #59

merged 13 commits into from
Feb 4, 2022

Conversation

GianFree
Copy link
Contributor

@GianFree GianFree commented Feb 3, 2022

Let me know whether you prefer a PR per function, or to group several of them into a single request.

@GianFree GianFree requested a review from v1j4y February 3, 2022 20:01
@v1j4y
Copy link
Contributor

v1j4y commented Feb 3, 2022

Let me know whether you prefer a PR per function, or to group several of them into a single request.

I would prefer as few PRs as possible since that saves review time. This would also help unforeseen changes encounter at a later date.

v1j4y
v1j4y reviewed Feb 4, 2022
View reviewed changes
Copy link
Contributor

@v1j4y v1j4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good up to now.

Would you like to merge this or keep pushing to this PR (with a name change) for other functions also ?

org/qmckl_jastrow.org Show resolved Hide resolved
@v1j4y v1j4y merged commit db27b06 into TREX-CoE:master Feb 4, 2022
@GianFree GianFree deleted the compute_asymp_jasb_c branch February 4, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1j4y v1j4y v1j4y left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GianFree @v1j4y