Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of the spec #111

Merged
merged 29 commits into from
Oct 8, 2024
Merged

Rewrite of the spec #111

merged 29 commits into from
Oct 8, 2024

Conversation

pietercolpaert
Copy link
Member

@pietercolpaert pietercolpaert commented Apr 24, 2024

This PR:

This indirectly also closes #92 (comment)

Decided during the 2024-09-05 meeting:

  • The discovery specification will at this point be made a draft report
  • The traversal spec can still be improved, but is better than ever before at this point

@pietercolpaert pietercolpaert changed the title Splitting off and rewriting the Discovery specification Rewrite of the spec Sep 2, 2024
@pietercolpaert
Copy link
Member Author

Ready for review

Copy link
Contributor

@bergos bergos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only some minor comments.

01-tree-specification.bs Outdated Show resolved Hide resolved
01-tree-specification.bs Outdated Show resolved Hide resolved

A client SHOULD be initiated using a URL.
The client MUST dereference the URL, which will result in a set of [[!rdf-concepts]] triples or quads.
When the URL after all redirects, is used in a triple `?c tree:view <> .`, a client MUST assume the URL after redirects is an identifier of the intended root node of the collection in `?c`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, in general, that logic should be used when consuming RDF data from the Web. Can we move it to another place of the spec so it's clear that the logic would apply also for any other resource?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure what exactly to do here. Is it unclear later in the text?

03-discovery-specification.bs Outdated Show resolved Hide resolved
Copy link
Contributor

@xdxxxdx xdxxxdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 My comments on the left/right hands have been addressed, small typos might need to be fixed @pietercolpaert Thanks!

03-discovery-specification.bs Outdated Show resolved Hide resolved
01-tree-specification.bs Outdated Show resolved Hide resolved
01-tree-specification.bs Outdated Show resolved Hide resolved
01-tree-specification.bs Outdated Show resolved Hide resolved
01-tree-specification.bs Outdated Show resolved Hide resolved
@pietercolpaert
Copy link
Member Author

Thanks! Processed your feedback @xdxxxdx and @bergos!

@pietercolpaert
Copy link
Member Author

Thanks for the feedback @julianrojas87! I’ll merge the PR now. Further issues and feedback can be given by opening a new issue now.

@pietercolpaert pietercolpaert merged commit d527cf6 into master Oct 8, 2024
3 checks passed
@pietercolpaert pietercolpaert deleted the split-discovery branch October 8, 2024 10:58
github-actions bot added a commit that referenced this pull request Oct 8, 2024
SHA: d527cf6
Reason: push, by pietercolpaert

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 8, 2024
SHA: d527cf6
Reason: push, by pietercolpaert

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 8, 2024
SHA: d527cf6
Reason: push, by pietercolpaert

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client and Server Implementation Guidelines for Common HTTP Use cases
4 participants