🚀 Add checkpointing policy #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaartenS11
force-pushed
the
feat/checkpointing
branch
from
3237c15 to
78f9fe7
Compare
tolauwae
changed the title
tolauwae
changed the title
MaartenS11
force-pushed
the
feat/checkpointing
branch
4 times, most recently
from
e9a187e to
09b804d
Compare
A checkpoint is taken at primitives and every x instructions. When the VM is paused it also makes a checkpoint so the debugger knows where the other snapshots are relative to the current point in time and so it can also display what the current state of the vm is. TODO: Will need to be extended a bit when using multiverse debugging. Choicepoints should have checkpoints right after reading sensor values so you don't have to remember the sensor value.
…eckpoint after instead of before primitive calls
…ns of the program
Also send any checkpoints right before the STEP!.
MaartenS11
force-pushed
the
feat/checkpointing
branch
from
8b91314 to
b95b266
Compare
MaartenS11
force-pushed
the
feat/checkpointing
branch
from
b95b266 to
7ec06c9
Compare
|
Quick question: can I also have the vm only snapshot after primitive calls, so not at regular intervals? @MaartenS11 |
|
✨ PR also adds the "continue for" debug operation |
There is currently no option for this, to simulate this I just used a very large checkpointing interval. |
MaartenS11
force-pushed
the
feat/checkpointing
branch
from
eb7b6b4 to
c6b91d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a snapshot policy that doesn't take snapshots at every instruction but every x instructions and at primitive calls (for reversibility). Because the debugger has to know when these snapshots were taken in relation to each other it will also report how many instructions were executed since the last checkpoint was made. A checkpoint is also made when the vm is paused so that you know how many instructions were executed after the last checkpoint and so the debugger know the current execution state.