Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checked exceptions (MalformedURLException) from public ValueProvider methods creating URLs #13

Closed
jonashoef opened this issue Sep 15, 2021 · 0 comments
Closed

Remove checked exceptions (MalformedURLException) from public ValueProvider methods creating URLs #13

jonashoef opened this issue Sep 15, 2021 · 0 comments
Assignees
@jonashoef

Comments

@jonashoef
Copy link
Contributor

jonashoef commented Sep 15, 2021 •
edited
Loading

The checked exceptions (MalformedURLException) unnecessarily complicate code using the respective ValueProvider methods.
If the generated URL is malformed, the methods should rather wrap the MalformedURLException in a runtime exception.

In addition, the 'decorations' should be applied to the passed domain string just as for other string based properties.
@jonashoef jonashoef self-assigned this Sep 15, 2021
jonashoef added a commit that referenced this issue Sep 15, 2021
@jonashoef
Replace potential (checked) MalformedURLException with (runtime) Ille…
9acca61 
…galArgumentException to ease using URL-related methods.

Issue #13

Signed-off-by: Jonas Höf <jonas.hoef@tngtech.com>
jonashoef added a commit that referenced this issue Sep 15, 2021
@jonashoef
Use static import
d3576f0 
Issue #13

Signed-off-by: Jonas Höf <jonas.hoef@tngtech.com>
jonashoef added a commit that referenced this issue Sep 16, 2021
@jonashoef
ensure string decoration for passed domain in URL-related methods
77f267d 
Issue #13

Signed-off-by: Jonas Höf <jonas.hoef@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonashoef jonashoef

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonashoef @stefanhechtltng