Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DB to SQL #963

Merged
merged 193 commits into from
Oct 22, 2022
Merged

Change DB to SQL #963

merged 193 commits into from
Oct 22, 2022

Conversation

Dudrie
Copy link
Collaborator

@Dudrie Dudrie commented Aug 3, 2021 •
edited
Loading

🎫 Description

Changes the used database from a MongoDB to a MySQL database. More information can be found in #957.

🔒 Closes

🐛 Issues

  • Attendances partially disappear after reloading the site.
  • Assessments: If you enter an assessment for a team and changes it afterwards (before going back to the overview) the server runs into an exception ("Students have different gradings.").
    -> This is only an issues for teams with exactly one student in it.
  • Presentations disappear after reloading the site.
  • Assessments don't get properly deleted if the corresponding hand-in gets deleted.
  • Substitutes: Saving substitutes fails.

Dudrie added 30 commits April 16, 2021 20:12
@Dudrie
Add Mikro-ORM dependencies.
3a17842
@Dudrie
Add basic module for SQL database.
6e3eb0a 
This one will be adjusted in the future.
@Dudrie
Add ER model for the SQL entitities.
0102d96 
This model is close to the current mongo documents. However, it can be changed/adjusted to better fit a sql database.
@Dudrie
Add ts-morph metadata provider.
b36f161
@Dudrie
Change prettier formatting settings.
ebed7e1
@Dudrie
Add uuid package.
db464f3
@Dudrie
Add entities: User, Tutorial, Student, Team & Attendance.
388d16e
@Dudrie
Add speciel types for luxon DateTime objects.
4ae415f
@Dudrie
Add missing entities (without relations).
148cdfb
@Dudrie
Add relationships to entities.
5afebf5
@Dudrie
Update ER-Model.
a310791
@Dudrie
Add constructor to user entity.
482ae8f
@Dudrie
Add missing constructors to entities.
8265cbc 
There is no "!" used anymore in the entities.
@Dudrie
Change dev build in server to ignore test folder & files.
c740433
@Dudrie
Fix types for mikro-orm for arrays of embeddables.
c35577b
@Dudrie
Load SqlDatabaseModule on server start.
9282822
@Dudrie
Change Attendance to be an Embedabble instead of Entity.
38b2788
@Dudrie
Switch DB from postgresql to mysql.
cf06b81
@Dudrie
Add first few helper functions in the entity.
2b7c1b5
@Dudrie
Add more helper methods on entites.
dd0ce66
@Dudrie
Add more helper methods & properties.
b841c1f
@Dudrie
Rename HandInDocument (SQL-Entity-Interface) -> HandIn
8b24eb7
@Dudrie
Add create & update event hooks to hash passwords of users.
9397e10
@Dudrie
Add hashing of user passwords on create / update.
e520064
@Dudrie
Add proper database connection handling on server start.
60f2a5e 
Tries to connect to the database when the server starts. If it can't connect, it'll  throw an error. If it can the SQLDatabaseModule ensures that

a) the database exists (if not it gets created).

b) the schema of the database matches the required one (if not it gets safely updated).
@Dudrie
Add first draft of an EncryptionSubscriber.
e025179
@Dudrie
Add custom type for encryption.
a798e4b 
Those types are better suited for the job than the EventSubscriber because they allow easier conversion between encrypted string value and actual value stored in the property while using the correct types.
@Dudrie
Add WebStorm project files.
6cb6555
@Dudrie
Add types to encrypt enums and arrays of enums.
a9bfd2c
@Dudrie
Clean up code.
9ff5153
Dudrie and others added 27 commits October 3, 2022 11:59
@Dudrie
Fix .npmrc file not being copied.
5ff4f8e
@Dudrie
Fix validating against a mongo ID not a UUID.
b7520d4
@Dudrie
Fix not using session entity.
2c8bd46
@Dudrie
Fix typo in comment.
304ca23
@Dudrie
Change logger messages to not use "document" anymore.
5877166
@Dudrie
Fix wrong query object used.
2506013 
This lead to an "@>" being included in the generated SQL query.
@Dudrie
Change to fetch all students after create/edit/delete operations.
be7ae3c
@Dudrie
Fix wrong id field being used for guard.
065da1e
@Dudrie
Fix wrong routes used for gradings.
f9ad312
@Dudrie
Fix missing dependency in useEffect hook.
84c706c
@Dudrie
Fix typos.
5ff3b83
@Dudrie
Add new function to set a grading for a whole team.
31d2efa
@Dudrie
Fix calculation of total points.
dd16dee
@nk-coding
fix error when updating grading of team with one student
39228ed
@nk-coding
do not use fork and use RequestContext instead
f0fb1e3
@nk-coding
fix imports
b800d7f
@nk-coding
allow global context during testing
ca49665
@nk-coding
fix substitution
9958a35
@nk-coding
fix incorrect query logic of 'Students have different gradings.'
76dd0d8
@nk-coding
format
f3b3864
@nk-coding
no fork in test
6c1d167
@nk-coding
remove forks in grading service
706b0fe
@nk-coding
remove remaining forks, fix delete tutorial
c2a3d69
@nk-coding
format
3e13efb
@nk-coding
fix context bug in tests
e22a164
@nk-coding
remove unused injected orm
a626004
@nk-coding
Merge pull request #1016 from nk-coding/bugfix/change_db_to_sql
03c068c 
Bugfix/change db to sql
@Dudrie Dudrie marked this pull request as ready for review October 22, 2022 10:00
@nk-coding nk-coding merged commit f313021 into main Oct 22, 2022
@nk-coding nk-coding deleted the issue-957-Change_DB_to_SQL branch October 22, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Dudrie Dudrie

Labels
📖 documentation Improvements or additions to documentation 🚀 performance Impacts performance 🗄 server Issue is related to the sever
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change DB to SQL
2 participants
@Dudrie @nk-coding