Add settings for the admin #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The component got unusable if it was in preview mode and the value got resetted to ''. Now, the button component stays clickable if the user is in preview mode, regardless of the value of the input.
Dudrie
added
🗄 server
Message get a colroed 'label' prefix instead of getting colored as a whole.
The first is the format SettingsServer the last (new one) will be used for the admin settings.
This allows the admin to define the default settings before the first start of the server.
This combines the ones from the config file with the internal ones used as a fallback.
This replaces the (default) usage of the MemoryStore of express-session.
This also extends the eslint scripts in the server package.json to include the test/ folder.
This also adds the usage of the defaultTeamSize.
The roles in the DTO should be a standard JS array. However, besides failing tests, this did not have any implications for the app because the type information was lost by strinigfying the response bodies to JSON anyway.
This helper allows a unified check if the current user is allowed to excuse a student.
Trying to load the settings before logging in results in a 401 error code and the settings were never re-fetched.
This also changes a lot of the logic in this service and cleans it up. This way it is more maintainable and readable (and hopefully less error prone).
If no fields where given to the SettingsModel constructor an empty object was assigned to mailingConfig instead of undefined.
This also changes the order of the inputs on the email settings.
- Mailing is disabled (this also disables the button to send the credentials to all users) OR - User has no email address OR - User has no temporary password. The reason is displayed to the user as secondary text except for the first one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Description
Add a system that allows the admin to change some settings without tinkering with configuration files. More infos in the issue #503.
This PR also changes some style and QoL related things.
🔒 Closes