Puppeteer to gotenberg #1059
Merged
Puppeteer to gotenberg #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nk-coding
requested changes
Oct 20, 2024
server/config/production.yml
Outdated
| puppeteer: | ||
| # Settings used for the gotenberg instance | ||
| gotenberg: | ||
| host: 'http://localhost' |
There was a problem hiding this comment.
you sure?
in production this should be deployed via docker / k8s, right?
shouldn't this then be sth like gotenberg or so (depending on one names the docker container)?
see above for database, there it is named tms_sql
There was a problem hiding this comment.
I adapted the files, hopefully as expected.
There are also mentions of puppeteer in the dockerfile and some docs files that reference build-test-docker/buildAndTestDocker.ts script as it existed only because of puppeteer. Should it be removed?
There was a problem hiding this comment.
tbh lets just get rid of it
nk-coding
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Description
Replace puppeteer with gotenberg