Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix csv upload: accept correct content type #1017

Merged
merged 2 commits into from
Oct 23, 2022

Conversation

nk-coding
Copy link
Collaborator

🎫 Description

Fixes the bug that the csv import loads forever.

  • replaces hardcoded .csv in accept with the content types
  • remove check for content type afterwards as it is now already checked by the upload itself (therefore it can never be an invalid content type), and if the validation fails it would only cause the bug of an infinite load
  • changes the content type for the csv import to text/csv, as application/vnd.ms-excel seems to be .xls and not .csv

🔒 Closes

@nk-coding nk-coding requested a review from Dudrie October 23, 2022 06:26
@nk-coding nk-coding merged commit 8bfe403 into TMS-Uni-Stuttgart:main Oct 23, 2022
@nk-coding nk-coding deleted the bugfix/csv_import branch October 23, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import user from csv
2 participants