-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up event ref for deletion of docs associated with deleted branch #216
Conversation
Documentation available at: |
Ahhh - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets see what happens.... 🤞
This is progress. It's targeting the right branch for docs deletion now, and the remaining error is a different issue (probably just a bad state in the |
Because of incomplete/buggy past firing of documentation-related CI tasks, the @e-lo, it appears that the deletion automatically reset the branch source for docs publication. I don't have direct access to the settings needed to set that source again. Can you do the following for me?
Let me know when that's done, and I'll continue some testing. |
I'm guessing we also need to point the source at /docs instead of at the root folder of the repository. Can you do that? |
It should build to root not docs...i thought? I just switched to docs to see. |
That was speculative - looking closer, it looks like top-level should be correct since we've got I think we've possibly done conflicting things while both trying to remedy this simultaneously, which is part of why the docs site isn't yet up. If we switch the source ref back to the root folder, and then run the full pages build and deployment process, hopefully that'll bring us back to where we should be. |
Katrina switched the ref back this morning. I'll continue to test and keep you posted! |
@e-lo, I've confirmed that the deletion workflow now functions correctly, and that the docs section creation process also works upon a new PR from a repo branch - I triggered the creation action anew on #212 and #214 by making small copy changes to those PRs. I believe the only remaining current need is to reset the default version used by Mike to redirect people who visit the root of https://tides-transit.github.io/ (or https://tides-transit.org/) to the proper version of the docs. I wasn't sure what was used as a default before, so I didn't set one unilaterally. Currently, all active repo branches are present in the Mike selector (i.e. built in the |
fixed! |
Pull Request
Changes the branch lineage referenced in
clean-docs.yml
so that older docs versions associated with a branch's deletion event are targeted correctly for deletion, rather than the docs associated with the head branch after that event has happened. This is a follow-up to #215.The event trigger behavior and the resulting branch ref was tested on a private repo before creating this PR.