[SNAP-2366] row buffer fault-in, forced roll-over #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
May 30, 2018 05:35
- Reason is that the "regionContext" set inside ColumnFormatValue (via base SerializedDiskBuffer) always remains a PlaceHolderRegion and never changes to a Region. So ColumnFormatValue cannot update the size stats when required. - Now invoke the setDiskEntry method in AbstractRegionEntry.setOwner too to fix above. - Other minor cleanups and a method rename.
- force fault-in in MemHeapScanController for row buffer iterations;
added RegionEntryUtils.fillRowFaultInOptimized for the same
- also fault-in regular row table data for qualified entries if there were any
filters that were pushed down to the scan level
- update region last modified time for destroy/invalidate and transactions ops too
(to determine idle time for forced roll-over)
- add a Predicate check just before actual rollover in BucketRegion under the lock
- added a StoppableReentrantReadWriteLock.lockDelayCancel method to avoid a cancellation
check for the good case of successful lock acquisition in first try (cancellation check
will be done in any case if lock could not be acquired in first try)
- perf improvement: replaced TStateless* classes by Koloboke maps/sets - removed now obsolete TStateless* classes
…iling - new PURGE_CODEGEN_CACHES procedure to clear codegeneration caches - removed trove extensions THashMapWithCreate, TObjectLongHashMapWithIndex and replace with koloboke maps; also some usages of TObjectIntHashMap in TX code path replaced - optimized CustomEntryConcurrentHashMap iteration by using a local expandible array for copying current chain instead of an ArrayList - made ObjectObjectHashMap serializable by implementing Externalizable
added 17 commits
June 6, 2018 12:54
Conflicts: gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java
- skip SYS tables from memory accounting; this fixes failures in snappy UMM accounting tests where storage size may change after restart because of SYS entry initializations in different order by hive meta-store initialization - skip destroyed entries in ObjectSizer row count - reduce per-table entries from 100K to 40K in PersistenceRecoveryOrderDUnit and use batch inserts instead of single inserts; this reduces running time of couple of tests in the suite to 30s from 4mins - also fixed occasional failures in PersistenceRecoveryOrderDUnit by explicitly dropping tables in correct order (after starting a new server in a test for the same)
sumwale
force-pushed
the
snappy/master
branch
2 times, most recently
from
337768c
to
ec453a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
added RegionEntryUtils.fillRowFaultInOptimized for the same
filters that were pushed down to the scan level
(to determine idle time for forced roll-over)
check for the good case of successful lock acquisition in first try (cancellation check
will be done in any case if lock could not be acquired in first try)
and Snappy caches); actual implementation of procedure body in snappydata layer
replace with koloboke maps; also some usages of TObjectIntHashMap in TX code replaced
for copying current chain instead of an ArrayList
Patch testing
precheckin
ReleaseNotes changes
new SYS.PURGE_CODEGEN_CACHES() procedure
Other PRs
TIBCOSoftware/snappydata#1046