Conviva #2
Merged
Conviva #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/conviva implementation * Implement Conviva connector * Simplify * Simplify clearInterval * Move YospaceConnector from constructor to function * Add comment * Add documentation * Add optional to yospace dependency Approved-by: Mattias Buelens Approved-by: Jeroen Veltmans
Update CI * Update CI * Remove unused README * Update readme to match new API Approved-by: Mattias Buelens
🦋 Changeset detectedLatest commit: 9bea384 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MattiasBuelens
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
LGTM!
For other reviewers: it's probably easier to review starting from this merge commit. See: 001cbb9...conviva
georgechoustoulakis
force-pushed
the
conviva
branch
from
ffb1dc9
to
9bea384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the THEOplayer Conviva connector to the monorepo, and makes a few fixed to make it compatible with the newest Yospace Connector version.