STM8L-DISCOVERY: enable UART output #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BOARDINIT routine from STM8L-DISCOVERY/boardcore.inc remaps UART interface to PA2/PA3 pins but the PA2 output mode set code is missed. As a result UART produces no output. The commit fixes the problem by setting up PA2 as push-pull output. Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
|
Hi Antony, thanks for fixing STM8L support (where I'm guilty of neglect ;-) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BOARDINIT routine from STM8L-DISCOVERY/boardcore.inc
remaps UART interface to PA2/PA3 pins but the PA2 output
mode set code is missed. As a result UART produces
no output.
The commit fixes the problem by setting up PA2 as
push-pull output.