Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution guidelines #66

Closed
larsbrinkhoff opened this issue Sep 22, 2017 · 3 comments
Closed

Contribution guidelines #66

larsbrinkhoff opened this issue Sep 22, 2017 · 3 comments
Assignees

Comments

@larsbrinkhoff
Copy link
Collaborator

I suggest it might be good to add some brief contribution guidelines. Such as, what is the branching strategy involving master and develop?

Note that if it's named exactly CONTRIBUTING.md, GitHub will take notice and offer it for display when users make pull requests.

@TG9541
Copy link
Owner

TG9541 commented Sep 22, 2017

I've had that on my todo list for a long time. Do you know of a good&simple example?

Of course feature branches, merging to develop, and then merging to master is a good idea. Also guidelines or suggestions for other forms of contributions might be worth thinking of (Wiki, Gists, application code).

@TG9541 TG9541 self-assigned this Sep 22, 2017
@larsbrinkhoff
Copy link
Collaborator Author

@TG9541
Copy link
Owner

TG9541 commented Sep 23, 2017

Thanks, that's great!

  • the Puppet rules are more than a bit over the top for this project (but still very instructive).
  • the stratum rules fit the bill
  • I like the sixtyforth style guide (with an assembly supplement)
  • I'd like to add some guidance on Open Source contributions (ISC style?)

I made a Gist with a draft. I'm looking forward to comments and improvements!

@TG9541 TG9541 closed this as completed in b357b91 Sep 29, 2017
TG9541 added a commit that referenced this issue Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants