Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect description forth.asm #34

Closed
barewires opened this issue Jun 12, 2017 · 7 comments
Closed

Incorrect description forth.asm #34

barewires opened this issue Jun 12, 2017 · 7 comments
Assignees
Labels

Comments

@barewires
Copy link

; 2/ ( n -- n ) ( TOS STM8: -- Y,Z,N )
; Multiply tos by 2.

@RigTig
Copy link
Collaborator

RigTig commented Jun 12, 2017

The perils of copy-and-paste strike again. 2/ is almost the same as 2*, well, in assembler source code if not in effect!

@barewires
Copy link
Author

barewires commented Jun 12, 2017 via email

@TG9541 TG9541 self-assigned this Jun 12, 2017
@TG9541
Copy link
Owner

TG9541 commented Jun 12, 2017

That's a genuine Dr. Ting artifact, I s'pose. Fixed. Comes with the next relase. My all time favorite was the one too many "end call optimization" in COMPILE. I found it when I implemented CREATE...DOES>, it had a really weird effect on the return stack, and I still don't fully understand why STM8EF worked at all.

@barewires:

  1. could you please tell me which release of SDCC you're using on the Pi?
    Compiling the latest version of SDCC on a PI3 might work (but it would be best to use a fast USB disk since the 700MiB of data compiling SDCC creates amounts to torturing an SD Card).
  2. There is nothing wrong with the direction of the diode :-)
  3. My wife and I still giggle about the PDP-8

@TG9541 TG9541 closed this as completed Jun 12, 2017
@barewires
Copy link
Author

barewires commented Jun 13, 2017 via email

@barewires
Copy link
Author

barewires commented Jun 13, 2017 via email

TG9541 added a commit that referenced this issue Jun 15, 2017
@TG9541 TG9541 added the bug label Jun 16, 2017
@TG9541
Copy link
Owner

TG9541 commented Jun 16, 2017

Hi Roy,
I've never tested SDCC 3.4.0 (according the the SDCC homepage STM8 support was introduced with 3.4.0) but I don't think the assembler has changed much (3.6.0 uses sdasstm8 "Assembler V02.00 + NoICE + SDCC mods (STMicroelectronics STM8)").
The whitespace after -o works with SDCC 3.6.0, and also with the latest development snapshot SDCC 3.6.6. However, the whitespace is inconsistent with the rest of the parameters and it's all but impossible that someone removes it in the future.

hexagon5un pushed a commit to hexagon5un/stm8ef that referenced this issue Jul 6, 2017
* upstream/master: (30 commits)
  Glossary updated, prepare release
  >NAME was included by default
  Optimize STC code of M* and M/MOD, see comment to c4f64b6
  issue TG9541#36: comments in forth.asm
  issue TG9541#36: comments in forth.asm
  New option BOOTSTRAP, corrections BAREBONES and UNLINKCORE
  Create forth.asm
  fixes TG9541#27 COMPILE handles CALLR incorrectly
  remove $¨| (even in the eForth source it's unclear what it does)
  fixes TG9541#34 incorrect description in glossary
  Use relative addressing some more (tested with MAXDEV)
  make USE_CALLDOLIT less broken (it still is)
  Move barebones files into own directory
  remove bad/unused words; updates 4 barebones
  Catch up with changes in TG9541/master
  Another tool moved into tools folder
  Put useful tool into tools folder
  First cut at TCP-based file loader
  issue TG9541#32: start building  infrastructure
  for headerless mode use UNLINKCORE instead of BAREBONES
  ...
@larsbrinkhoff
Copy link
Collaborator

@barewires I have my Forth cross compiler generating code for the PDP-8. Just saying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants