Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructor: add rank question: prevent input field from shrinking when enabled #8355

Closed
bqnguyen94 opened this issue Jan 25, 2018 · 2 comments · Fixed by #8360
Closed

Instructor: add rank question: prevent input field from shrinking when enabled #8355

bqnguyen94 opened this issue Jan 25, 2018 · 2 comments · Fixed by #8360
Assignees
@tshradheya
Labels
a-UIX User Interface, User eXperience, responsiveness help wanted Moderate difficulty, small localized change; suitable for novice contributors p.Low Very little impact; unlikely to do in the near future
Milestone
V6.1.0

Comments

@bqnguyen94
Copy link
Contributor

bqnguyen94 commented Jan 25, 2018 •
edited
Loading

Environment

master branch at commit 18aefe8
Browser: Chrome on macOS High Sierra

Steps to reproduce

  • Login as instructor
  • Go to instructor home page, click edit on any feedback session
  • Go to bottom of page, click Add New Question, choose either Rank 'options' question or Rank 'recipients' question, tick on either Minimum number of options a respondent must rank or Maximum number of options a respondent can rank, the corresponding input field will shrink

Expected behaviour
The input fields should not shrink when enabled

Actual behaviour
The input fields shrink when enabled

Possible cause
When the input field is enabled, the max attribute is added to it. The field now has both min and max attributes and the size of the field is then changed to fit the amount of digits specified by max (see angular/material#7349).

Proposed solution
Set the step attribute of input field to any so that the input field does not try to fit the maximum length of input.
@damithc damithc changed the title HTML: number input: input field shrinks when enabled Instructor: add rank question: prevent input field from shrinking when enabled Jan 25, 2018
@damithc damithc added a-UIX User Interface, User eXperience, responsiveness p.Low Very little impact; unlikely to do in the near future t-HTML help wanted Moderate difficulty, small localized change; suitable for novice contributors labels Jan 25, 2018
@Shashwat-Garg
Copy link
Contributor

Hello, I would like to work on this issue.

@reddysridhar53
Copy link

Shall I pick this one?

@tshradheya tshradheya mentioned this issue Jan 26, 2018
Merged
xpdavid pushed a commit that referenced this issue Jan 31, 2018
@tshradheya @xpdavid
[#8355] Fix shrinking of Input feild for Rank Recipient/Options quest…
b0ff1c9 
…ion (#8360)

* Rank options question: fix shrinking

* Updated order

* Updted test resources after GodMode

* Revert changes

* Revert unnecessary changes
@whipermr5 whipermr5 added this to the V6.1.0 milestone Jan 31, 2018
@whipermr5 whipermr5 added the e.2 label Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tshradheya tshradheya

Labels
a-UIX User Interface, User eXperience, responsiveness help wanted Moderate difficulty, small localized change; suitable for novice contributors p.Low Very little impact; unlikely to do in the near future
Projects
None yet
Milestone
V6.1.0
Development

Successfully merging a pull request may close this issue.

Fix shrinking of Input feild for Rank Recipient/Options question #8355 tshradheya/teammates
6 participants
@damithc @reddysridhar53 @whipermr5 @bqnguyen94 @tshradheya @Shashwat-Garg