[#1501] Create Unit Tests for Feedback*QuestionDetails classes (#12479)

* Added test cases for shouldChangesRequireResponseDeletion method

* changed to newNumDetails where needed

---------

Co-authored-by: EuniceSim142 <77243938+EuniceSim142@users.noreply.github.com>

src/test/java/teammates/common/datatransfer/questions/FeedbackMsqQuestionDetailsTest.java

@@ -421,6 +421,17 @@ public void testShouldChangesRequireResponseDeletion_differentMsqChoices_shouldR
         assertTrue(msqDetails.shouldChangesRequireResponseDeletion(newMsqDetails));
     }
 
+    @Test
+    public void testShouldChangesRequireResponseDeletion_differentNumberMsqChoices_shouldReturnTrue() {
+        FeedbackMsqQuestionDetails msqDetails = new FeedbackMsqQuestionDetails();
+        msqDetails.setMsqChoices(List.of("choice1", "choice2"));
+
+        FeedbackMsqQuestionDetails newMsqDetails = new FeedbackMsqQuestionDetails();
+        newMsqDetails.setMsqChoices(List.of("choice1", "choice2", "choice3", "choice4"));
+
+        assertTrue(msqDetails.shouldChangesRequireResponseDeletion(newMsqDetails));
+    }
+
     @Test
     public void testShouldChangesRequireResponseDeletion_differentGenerateOptionsFor_shouldReturnTrue() {
         FeedbackMsqQuestionDetails msqDetails = new FeedbackMsqQuestionDetails();

src/test/java/teammates/common/datatransfer/questions/FeedbackNumericalScaleQuestionDetailsTest.java

@@ -114,7 +114,7 @@ public void tesValidateResponseDetails() {
     }
 
     @Test
-    public void tesValidateQuestionDetails() {
+    public void testValidateQuestionDetails() {
         FeedbackNumericalScaleQuestionDetails numScaleQuestion = new FeedbackNumericalScaleQuestionDetails();
 
         ______TS("Test Default no error");
@@ -142,4 +142,52 @@ public void tesValidateQuestionDetails() {
         assertEquals(FeedbackNumericalScaleQuestionDetails.NUMSCALE_ERROR_MIN_MAX, errors.get(0));
         assertEquals(FeedbackNumericalScaleQuestionDetails.NUMSCALE_ERROR_STEP, errors.get(1));
     }
+
+    @Test
+    public void testShouldChangesRequireResponseDeletion_differentMinScale_shouldReturnTrue() {
+        FeedbackNumericalScaleQuestionDetails numDetails = new FeedbackNumericalScaleQuestionDetails();
+        numDetails.setMinScale(1);
+
+        FeedbackNumericalScaleQuestionDetails newNumDetails = new FeedbackNumericalScaleQuestionDetails();
+        newNumDetails.setMinScale(3);
+
+        assertTrue(numDetails.shouldChangesRequireResponseDeletion(newNumDetails));
+    }
+
+    @Test
+    public void testShouldChangesRequireResponseDeletion_differentMaxScale_shouldReturnTrue() {
+        FeedbackNumericalScaleQuestionDetails numDetails = new FeedbackNumericalScaleQuestionDetails();
+        numDetails.setMaxScale(5);
+
+        FeedbackNumericalScaleQuestionDetails newNumDetails = new FeedbackNumericalScaleQuestionDetails();
+        newNumDetails.setMaxScale(2);
+
+        assertTrue(numDetails.shouldChangesRequireResponseDeletion(newNumDetails));
+    }
+
+    @Test
+    public void testShouldChangesRequireResponseDeletion_differentStep_shouldReturnTrue() {
+        FeedbackNumericalScaleQuestionDetails numDetails = new FeedbackNumericalScaleQuestionDetails();
+        numDetails.setStep(0.5);
+
+        FeedbackNumericalScaleQuestionDetails newNumDetails = new FeedbackNumericalScaleQuestionDetails();
+        newNumDetails.setStep(2);
+
+        assertTrue(numDetails.shouldChangesRequireResponseDeletion(newNumDetails));
+    }
+
+    @Test
+    public void testShouldChangesRequireResponseDeletion_sameDetails_shouldReturnFalse() {
+        FeedbackNumericalScaleQuestionDetails numDetails = new FeedbackNumericalScaleQuestionDetails();
+        numDetails.setMinScale(1);
+        numDetails.setMaxScale(5);
+        numDetails.setStep(0.5);
+
+        FeedbackNumericalScaleQuestionDetails newNumDetails = new FeedbackNumericalScaleQuestionDetails();
+        newNumDetails.setMinScale(1);
+        newNumDetails.setMaxScale(5);
+        newNumDetails.setStep(0.5);
+
+        assertFalse(numDetails.shouldChangesRequireResponseDeletion(newNumDetails));
+    }
 }