Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index boundaries #82

Merged
merged 8 commits into from
Jul 27, 2020
Merged

Index boundaries #82

merged 8 commits into from
Jul 27, 2020

Conversation

duskoo
Copy link
Collaborator

@duskoo duskoo commented Jun 21, 2020

Tests TCN generation for boundary index values:
0, 1
1, 1
1, 2
1, 200
20, 90
20000, 30000
u16::MAX - 1, u16::MAX
u16::MAX, u16::MAX

@duskoo duskoo requested review from ivnsch and hdevalence and removed request for ivnsch June 21, 2020 10:07
@duskoo duskoo mentioned this pull request Jun 21, 2020
Closed
@duskoo duskoo requested a review from ivnsch June 21, 2020 10:19
@duskoo duskoo mentioned this pull request Jun 21, 2020
Open
ivnsch
ivnsch approved these changes Jun 29, 2020
View reviewed changes
Copy link
Collaborator

@ivnsch ivnsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't have the time now to review this properly, but given that it's only tests and I know the context, I'll accept.

@duskoo duskoo requested a review from ivnsch July 5, 2020 12:35
@duskoo duskoo merged commit b3cd600 into TCNCoalition:main Jul 27, 2020
@duskoo duskoo deleted the index-boundaries branch July 27, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivnsch ivnsch ivnsch approved these changes

@hdevalence hdevalence Awaiting requested review from hdevalence

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duskoo @ivnsch