Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version numbers missing on macOS #16

Closed
core-code opened this issue Mar 31, 2022 · 3 comments
Closed

version numbers missing on macOS #16

core-code opened this issue Mar 31, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@core-code
Copy link

i've downloaded version 1.2.2 but the version numbers are missing. all macOS apps are supposed to have version numbers. both the CFBundleVersion and the CFBundleShortVersionString entries are missing from your Info.plist file.

this is a regression. at least version 1.1.2 did contain proper version numbers (and a copyright notice).

Screenshot 2022-03-31 at 18 10 44

@TCB13
Copy link
Owner

TCB13 commented Mar 31, 2022

Hello.

This is indeed a regression caused by the complete rewrite of the application that took place in v1.2-1.2.1. Note that those releases also made the App way better for macOS. https://github.com/TCB13/LoFloccus/releases/tag/1.2.1

Thank you for noticing this. I'll have a look at it.

@TCB13 TCB13 self-assigned this Mar 31, 2022
@TCB13 TCB13 added the bug Something isn't working label Mar 31, 2022
TCB13 added a commit that referenced this issue Apr 1, 2022
@TCB13
Copy link
Owner

TCB13 commented Apr 1, 2022

Issue closed with the release of version 1.2.3. https://github.com/TCB13/LoFloccus/releases/tag/1.2.3

@TCB13 TCB13 closed this as completed Apr 1, 2022
@core-code
Copy link
Author

confirmed fixed, thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants