Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Add Opera GX compatibility #25

Closed
wants to merge 1 commit into from
Closed

feat:Add Opera GX compatibility #25

wants to merge 1 commit into from

Conversation

DedLad
Copy link

@DedLad DedLad commented Jul 22, 2024

Fixes #24 Issue

@TBM13
Copy link
Owner

TBM13 commented Jul 23, 2024

Thanks for the pull request. Here are some suggestions:

  • Chromium.cs is supposed to be as generic as possible. If we need browser-specific code, then another class should be made.
  • You've done a lot of code style changes, which are irrelevant to the objective of the pull request.
  • From what I could see, Opera GX seems to manage profiles different. It doesn't seem like you handle this
  • Comments look like instructions to make ChatGPT generate the code

I can't really merge this, but I'll be adding basic support for this browser (without profiles, since I couldn't even get them to work on my Opera GX installation)

@TBM13 TBM13 closed this Jul 23, 2024
@DedLad
Copy link
Author

DedLad commented Jul 23, 2024

It was not ChatGPT generated code, i certainly took help from it, but i have gotten OperaGX support on my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin incompatible with OperaGX
2 participants