Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the HTTP response body to a string type (PY3 this will be bytes) #239

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Convert the HTTP response body to a string type (PY3 this will be bytes) #239

merged 1 commit into from
Nov 12, 2019

Conversation

sddj
Copy link
Contributor

@sddj sddj commented Oct 30, 2019

No description provided.

@MarkDavidson
Copy link
Contributor

@emmanvg @clenk Can this be merged and rolled into a release of libtaxii? The error condition fixed in this PR is common and is important for migrating libtaxii to python3.

@emmanvg emmanvg added this to the libtaxii 1.1.115 milestone Nov 12, 2019
@emmanvg emmanvg self-requested a review November 12, 2019 20:50
emmanvg
emmanvg approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@emmanvg emmanvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sddj thanks for providing these changes. Sorry on the late turnaround, this should be available on the next release.

@emmanvg emmanvg merged commit cbdea91 into TAXIIProject:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanvg emmanvg emmanvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
libtaxii 1.1.115
Development

Successfully merging this pull request may close these issues.
3 participants
@sddj @MarkDavidson @emmanvg