-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change build config to support the Core build system (as well) #1702
Conversation
Please attach memorandum describing why gitlab CI matters |
I'd be against this if it has side effects in Visual Studio or MSBuild. After I moved everything into conditional imports it seems better but it needs more testing. |
632afaf
to
ad55c33
Compare
It's behaving well with Visual Studio / MSBuild now. @YoshiRulz can you make sure it still works for you as of my most recent commit? |
Does now. edit for @zeromus: AppVeyor's OSS plan doesn't allow for concurrent jobs. When we get unit tests, GitLab would be able to run those on Debug while compiling Release. edit 2: other than some warnings, dotnet from PS also works |
This is a helpful first step towards #1415. It's also a requirement for GitLab CI, which uses Docker.
req:
Ready to squash, though trying the changes on more machines couldn't hurt.
bonus: