Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change build config to support the Core build system (as well) #1702

Merged
merged 10 commits into from
Dec 3, 2019

Conversation

YoshiRulz
Copy link
Member

@YoshiRulz YoshiRulz commented Oct 21, 2019

This is a helpful first step towards #1415. It's also a requirement for GitLab CI, which uses Docker.

req:

  • msbuild on Windows
  • dotnet on Linux
  • dotnet on Windows

Ready to squash, though trying the changes on more machines couldn't hurt.

bonus:

  • msbuild on Linux (I think it will be deprecated soon anyway)
  • double-check build tool replacement

@zeromus
Copy link
Contributor

zeromus commented Oct 21, 2019

Please attach memorandum describing why gitlab CI matters

@jdpurcell
Copy link
Contributor

I'd be against this if it has side effects in Visual Studio or MSBuild. After I moved everything into conditional imports it seems better but it needs more testing.

@jdpurcell
Copy link
Contributor

It's behaving well with Visual Studio / MSBuild now. @YoshiRulz can you make sure it still works for you as of my most recent commit?

@YoshiRulz
Copy link
Member Author

YoshiRulz commented Oct 22, 2019

Does now.

edit for @zeromus: AppVeyor's OSS plan doesn't allow for concurrent jobs. When we get unit tests, GitLab would be able to run those on Debug while compiling Release.

edit 2: other than some warnings, dotnet from PS also works

@YoshiRulz YoshiRulz marked this pull request as ready for review October 26, 2019 12:22
@jdpurcell

This comment has been minimized.

@YoshiRulz YoshiRulz merged commit fcc0bc1 into master Dec 3, 2019
@YoshiRulz YoshiRulz deleted the dotnet-build branch December 3, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants