fix: tup-274 core-styles dependencies to root

[wesleyboar]

Overview

Move core-styles dependencies to root package.json.

But also tetain its dependencies as peerDependencies so any client repo can resolve the dependencies in a way that is compatible with tup-ui monorepo.

Simplify core-styles project.json.

I reduce complexity that seems unnecessary for core-styles.

Related

• TUP-274
• mirrored by feat: tup-274 peerDeps not deps Core-Styles#46

Changes

• install core-styles dependencies to the root
• list core-styles dependencies, internally, as peer dependencies*
• chore: simplify core-styles project.json

_{* By not using dependencies, internal to core-styles, a set of dependencies is not exactly duplicated from root. Instead, core-styles lists dependencies that it expects are installed (whether by TACC/tup-ui or TACC/Core-CMS† or TACC/Core-Portal). This works because peerDependencies are automatically installed, if not already installed (as of NPM v7).
† TACC/Core-CMS is not using TACC/tup-ui's core-styles, but it is supposed to in the future, so this change makes its build process remain compatible with TACC/Core-CMS. I am mirroring and testing this via TACC/Core-Styles#46 and TACC/Core-CMS#552.}

Testing

in TACC/tup-ui

0. Delete (if present): /dist, /libs/core-styles/node_modules, /libs/core-styles/dist.
1. From root, run npm ci.
2. From root, run nx run core-styles:build --skip-nx-cache.
3. Verify the lib builds without error.
4. From root, run nx run tup-ui:build --skip-nx-cache.
5. Verify the app builds without error finding a stylesheet.

✅ in TACC/Core-CMS (i.e. TACC/Core-CMS#552)

Already peer-tested via TACC/Core-CMS#552 for TACC/Core-Styles#46 (review).

1. Clone TACC/Core-CMS.
2. Checkout branch task/tup-274-core-styles-deps.
3. Build styles for any CMS project e.g.
   • npm run build --project=core-cms
   • npm run build --project=frontera-cms
4. Verify the app builds without error.¹²

Footnotes

1. A CMS stylesheet build error caused by a missing dependency will halt the build. ↩

2. An error caused by a missing stylesheet will not halt the build (known problem). Search for Error: Failed to find . ↩

[wesleyboar]

@rstijerina approved the same PR for TACC/Core-Styles standalone repo and performed the CMS test steps.

[wesleyboar]

Merging based on:

• local testing
• successful automated check
• successful peer test of change on Core-CMS and Core-Styles
• desire to have less outstanding PRs for Core Styles
• desire to have less outstanding discrepancies between TACC/Core Styles and TACC/tup-ui:libs/core-styles