Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core styles/v0.7.0 #30

Merged
merged 5 commits into from
Jul 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libs/core-styles/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
git-tag-version=false
25 changes: 24 additions & 1 deletion libs/core-styles/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,27 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.7.0] - 2022-07-15: New Global Color, Fix Section Banner on Safari

### Change

- release [0.7.0-beta] as [0.7.0]

## [0.7.0-beta] - 2022-07-13: New Global Color, Fix Section Banner on Safari

### Added

- feat(core-styles): tup-308, new global color #25

### Change

- feat(core-styles): add `.npmrc` with `git-tag-version=false`
- feat(core-styles): add git tagging to publish steps in readme

### Fixed

- fix(core-styles): fp-1723 fix o-section--banner on safari #29

## [0.6.0] - 2022-07-06: Fix CMS v3.7.0 Bugs, Button Style Updates

- [0.6.0-beta.3]
Expand Down Expand Up @@ -171,7 +192,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

Initial working code. (This code may not work on all environments.)

[unreleased]: https://github.com/TACC/tup-ui/compare/core-styles-v0.6.0...HEAD
[unreleased]: https://github.com/TACC/tup-ui/compare/core-styles-v0.7.0...HEAD
[0.7.0]: https://github.com/TACC/Core-Styles/releases/tag/core-styles-v0.7.0
[0.7.0-beta]: https://github.com/TACC/Core-Styles/releases/tag/core-styles-v0.7.0-beta
[0.6.0]: https://github.com/TACC/Core-Styles/releases/tag/core-styles-v0.6.0
[0.6.0-beta.3]: https://github.com/TACC/Core-Styles/releases/tag/core-styles-v0.6.0-beta.3
[0.6.0-beta.2]: https://github.com/TACC/tup-ui/releases/tag/core-styles-v0.6.0-beta.2
Expand Down
5 changes: 4 additions & 1 deletion libs/core-styles/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,11 @@ Only authorized team members may publish.
1. (one time) Login to npm i.e. `npm login`.
1. Create new branch for version bump.
1. Update `CHANGELOG.md`.
1. Update version via `npm version the.new.ver` (run from `.../core-styles/`).
1. Update version via `npm version N.N.N` (run from `.../core-styles/`).
1. Commit, push, PR, review, merge.
1. Tag version i.e.
1. `git tag -a core-styles-vN.N.N -m "vN.N.N"`
2. `git push origin core-styles-vN.N.N`
1. Publish to NPM via `npm publish --access public`.

> **Notice**: Project build will automatically occur before publish.
Expand Down
4 changes: 2 additions & 2 deletions libs/core-styles/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion libs/core-styles/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@tacc/core-styles",
"version": "0.6.0",
"version": "0.7.0",
"license": "MIT",
"author": "TACC ACI WMA <wma-portals@gmail.com>",
"description": "CSS source and processor for TACC Core-CMS and Core-Portal.",
Expand Down
23 changes: 3 additions & 20 deletions libs/core-styles/src/lib/_imports/objects/o-section.css
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,9 @@ Styleguide Objects.Section

/* Modifers: Banner */

.o-section--banner[class*="o-section--layout"] { gap: 0; }
.o-section--banner.container { padding-inline: 0; }
.o-section--banner { overflow: hidden; }
.o-section--banner [class*="o-section--layout"] { gap: 0; }
.o-section--banner .container { padding-inline: 0; }
.o-section--banner.o-section { padding-block: 0; }


Expand Down Expand Up @@ -253,24 +254,6 @@ Styleguide Objects.Section



/* Tricks: Children: Banner Image */
/* FP-1462: Extract to new banner component(s) */

/* To hide section overflow with minimal side effects */
/* FAQ: Use 'clip', not 'hidden' which can affect opposite 'overflow-' value */
/* NOTE: This selector assumes only a banner section has vertical overflow */
/* CAVEAT: Any banner pop-out el's would NOT overflow atop sibling sections */
[class*="o-section--style"].o-section--banner {
/* To hide vert. overflow */
overflow-y: clip;
}
main {
/* To hide horz. overflow yet support any 'position: sticky' descendant */
overflow-x: clip;
}



/* Tricks: Modifers: Style */

/* To prevent visibly extra space beneath certain sections and footer */
Expand Down
1 change: 1 addition & 0 deletions libs/core-styles/src/lib/_imports/settings/color.css
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
--global-color-warning--weak: #c7ce1d20;
--global-color-warning--alt: var(--global-color-accent--dark);
--global-color-warning--alt-weak: var(--global-color-accent--weak);
--global-color-danger--dark: #ab1717;
--global-color-danger--normal: #eb6e6e;
--global-color-danger--weak: #eb6e6e20;

Expand Down