Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/TUI-157 -- vite client #1

Closed
wants to merge 4 commits into from
Closed

task/TUI-157 -- vite client #1

wants to merge 4 commits into from

Conversation

jchuahtacc
Copy link
Contributor

Overview:

React application created with Vite

Related Github Issues:

Summary of Changes:

  • README
  • Add tup-ui client, built using Vite/react-ts
  • jest, eslint, prettier
  • Github workflows for building
  • PR request template

Testing Steps:

  1. Follow instructions in README.md for installing dependencies and running the default Vite "Hello World" app
  2. Run npm run test and npm run lint

UI Photos:

image

Notes:

wesleyboar
wesleyboar requested changes May 23, 2022
View reviewed changes
Copy link
Member

@wesleyboar wesleyboar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments. The npm install → npm ci is the only thing I care strongly about.

jchuahtacc and others added 2 commits May 23, 2022 13:06
@jchuahtacc @wesleyboar
Update .github/pull_request_template.md
da4ca09 
Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>
@jchuahtacc @wesleyboar
Update README.md
41233e6 
Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>
@wesleyboar wesleyboar self-requested a review May 23, 2022 18:53
jmartinez-tacc
jmartinez-tacc approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@jmartinez-tacc jmartinez-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jchuahtacc jchuahtacc closed this Jun 3, 2022
@wesleyboar wesleyboar deleted the task/TUI-157--vite-client branch October 10, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-tacc jmartinez-tacc jmartinez-tacc approved these changes

@wesleyboar wesleyboar wesleyboar approved these changes

@jarosenb jarosenb Awaiting requested review from jarosenb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchuahtacc @jmartinez-tacc @wesleyboar