Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(o-table-wrap): …scroll.extra → …scroll-extra #69

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 16, 2022

Overview

Fix bugs with table objects (i.e. #68).

Related

Changes

  • rename o-table-wrap--overflow-scroll.extrao-table-wrap--overflow-scroll-extra

Testing

  1. npm run build
  2. npx serve demo
  3. Confirm http://localhost:3000/components/detail/o-table-wrap--overflow-scroll-extra.html loads.
  4. Confirm O Table Wrap > Overflow Scroll (Extra) link in nav loads same page.

UI

Locally

fix fp-1878 overflow-scroll-extra

Remotely

remote tup-cms oversflow scrollextra

wesleyboar added a commit to TACC/Core-CMS that referenced this pull request Nov 16, 2022
wesleyboar added a commit to TACC/tup-ui that referenced this pull request Nov 16, 2022
Fixes load of one table object pattern demo page.

TACC/Core-Styles#69
wesleyboar added a commit to TACC/tup-ui that referenced this pull request Nov 16, 2022
Changes link color from Frontera's to TUP CMS's.

TACC/Core-Styles#69
wesleyboar added a commit to TACC/tup-ui that referenced this pull request Nov 16, 2022
@wesleyboar wesleyboar merged commit d4c966b into main Nov 16, 2022
@wesleyboar wesleyboar deleted the fix/fp-1878-table-object-bugs branch November 16, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant