Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-styles): pattern demo repair suite #66

Merged
merged 15 commits into from
Nov 14, 2022
Merged

fix(core-styles): pattern demo repair suite #66

merged 15 commits into from
Nov 14, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 14, 2022 •
edited
Loading

Overview

Many changes:

  • fix path bugs only noticed after testing on CMS
  • fix render bugs only noticed after testing on CMS
  • fix render bugs also visible on Core-Styles

Related

Changes

See Commit messages.

Testing

Core-Styles

  1. npm run build:css && npm start
  2. Open http://localhost:8000/static/ui/index.html.
  3. Verify each commit message fix.

Core-CMS

  1. npm run build
  2. Open http://localhost:8000/static/ui/index.html.
  3. Verify each commit message fix.

UI

Skipped. Too many to screenshot and organize.

@wesleyboar
fix: broken paths in client build
c148a6d 
The supportStyles fixes this problem, but it was not used everywwhere it should.
@wesleyboar
fix: remove unnecessary test styles
c9f2819 
When PostCSS was younger, I tested their plugins. They test their own well enough now.

Also, the existence of these was causing problems in Core CMS pattern library demo.

Ideally, I should solve the path problem in Core CMS. I probably will if this works, thus proving I do know where the problem is.
@wesleyboar
fix(c-button): missing short width class in markup
a37c32b
@wesleyboar
fix(links): drop old styles from html-elements.cms
bedb630
@wesleyboar
fix(links): overwrite bootstrap hover color
6548340
@wesleyboar
feat(x-links): add irregular links
812d84a 
So clients can extend irregular links, thus overwriting standard linsk with irregular ones, like CMS for ECEP website.
@wesleyboar
fix(x-link): overwrite bootstrap hover line thick
7227067
@wesleyboar
fix(c-button): auto max-width (not 100%)
369b5a1 
100% would be 100% width of contiabner. Seems undesirable, except maybe on Portal. But Portal already manages width specifically.

(I think I was moving to fast when I wrote 100%.)
@wesleyboar
fix(c-button): text align center for <a>
f9798a0
@wesleyboar
fix(c-button): remove extraneous --width-long
f0b71e8
@wesleyboar
fix(c-button): missing class and remove new line
6772deb
@wesleyboar
fix(c-button): no :focus ui if state --is-busy
76d7e85
@wesleyboar
fix(table): remove erroneous markup (noop)
15dd10a
@wesleyboar
fix(c-button): no font weight medium for --as-link
f2b493c
@wesleyboar
fix(c-button): --as-link font should inherit
445a5e5 
Bowser sets font for buttons, but this button should look like text (link).
@wesleyboar wesleyboar mentioned this pull request Nov 14, 2022
Merged
@wesleyboar wesleyboar changed the title fix: broken paths in client build fix(core-styles): pattern demo repair suite Nov 14, 2022
@wesleyboar wesleyboar merged commit 511c870 into main Nov 14, 2022
@wesleyboar wesleyboar deleted the fix/bugs-found-in-client-demo branch November 14, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar