Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elements): fp-1878 table pattern #64

Merged
merged 26 commits into from
Nov 13, 2022
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 13, 2022

Overview

Style basic tables, tables with paragraphs, and nested tables.

Related

Changes

  • add a one paragraph text snippet
  • change <li> line-height to not apply to tables
  • add table styles: basic, paragraph, nested

Testing

  1. Open /components/detail/table--basic.
    1. Verify styles match design.
    2. On narrow frame1, verify:
      1. first column is pinned
      2. other columns scroll
      3. no style oddities
  2. Open /components/detail/table--paragraph.
    1. Verify styles match design e.g. cell content is top-aligned.
    2. On narrow frame1, verify:
      1. first column is pinned
      2. other columns scroll
      3. no style oddities
  3. Open /components/detail/table--nested.
    1. Verify styles match design.
    2. On narrow frame1, verify:
      1. first column is pinned
      2. other columns scroll
      3. no style oddities
    3. On very narrow frame2, verify:
      1. first column, of nested table, is also pinned
      2. other columns, of nested table, scroll
      3. no style oddities

UI

Basic

Wide Narrow
basic wide basic narrow

Paragraph

Wide Narrow Very Narrow
paragraph wide paragraph narrow paragraph very narrow

Nested

Wide Narrow Very Narrow
nested wide nested narrow nested very narrow

Notes

Footnotes

  1. Narrow enough that table content can not horizontally fit. 2 3

  2. Narrow enough that nested table content can not horizontally fit.

@wesleyboar wesleyboar merged commit d5009dc into main Nov 13, 2022
@wesleyboar wesleyboar deleted the task/fp-1878-table-pattern branch November 13, 2022 20:43
wesleyboar added a commit to TACC/Core-CMS that referenced this pull request Nov 13, 2022
@wesleyboar wesleyboar changed the title Task/fp 1878 table pattern feat(elements): fp-1878 table pattern Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant