Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simple explicit header nav link padding #462

Merged
merged 5 commits into from
Mar 1, 2025

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 1, 2025

Overview

  • Simplify header nav link padding styles.
  • Make header nav link padding consistent.
    (i.e. overwrite Bootstrap's rem, which causes different space per client)

Related

Changes

  • renamed mixin from header__nav-link--tall to header--not-expanded
  • added absolute sizes for dropdown padding
  • scoped two styles to .s-header.

Testing & UI

  • Menu has zero change from before, especially .nav-link padding.
  • Menu has greater padding block when expanded.
not expanded is expanded
menu not expanded menu is expanded

@wesleyboar wesleyboar merged commit 85ebf82 into main Mar 1, 2025
@wesleyboar wesleyboar deleted the refactor/simple-explicit-header-nav-link-padding branch March 1, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant