Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use v2/cms colors for compact/portal messages #377

Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 28, 2024

Overview

Use CMS colors for Portal messages.

Designer has requested this indirectly several times. Doing this makes design-tokens and v3 easier.

Related

None.

Changes

  • deleted portal message colors
  • moved cms message colors to default message
  • changed cms message success border and icon bkgd color
  • refactored @extend :--c-message… to @mixin message…

Testing

  1. Open all components that are or use messages.
  2. Compare messages to main:
    before after
    bright green border dark green border
    bright green icon bkgd dark green icon bkgd
    thick portal border thin portal border
    ugly portal colors portal colors match cms

UI

before.mov
after.mov

@github-actions github-actions bot added the refactor Re-writes/structures code but retains behavior label Aug 28, 2024
@wesleyboar wesleyboar changed the title fix: extra dash in .x-message use of mixins refactor: use v2/cms colors for compact/portal messages Aug 28, 2024
@wesleyboar wesleyboar added the minor A feature in backward-compatible manner label Aug 28, 2024
@wesleyboar wesleyboar marked this pull request as ready for review August 28, 2024 23:43
@wesleyboar wesleyboar merged commit 68e2080 into main Aug 28, 2024
2 checks passed
@wesleyboar wesleyboar deleted the refactor/use-v2-ie-cms-colors-for-compact-ie-portal-messages branch August 28, 2024 23:43
wesleyboar added a commit that referenced this pull request Sep 9, 2024
* fix: revert portal "traffic" colors

* fix: revert portal message styles

* fix: revert portal form error styles

* Fix/revert-pr-377-manually-since-design-tokens (#396)

* fix: revert portal "traffic" colors

* fix: revert portal message styles

* fix: delete unrelated new file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor A feature in backward-compatible manner refactor Re-writes/structures code but retains behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant