Task/fp 1499 ui pattern demo - fp 1726 publications list #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TACC/tup-ui@a30002a TACC/tup-ui@24db51b TACC/tup-ui@141464f P.S. a30002a originates from TACC/tup-ui#38
No new solution for cross-repo testing this package (sans npm publish). I hve an idea, but for now I'll just commit the dist temporarily.
Last commit I accidentally added outdated files into temp. dist folder.
Let first pub preview have border, even if it is not the first element.
- limit citation styles to first paragraph - limit status styles to last paragraph (that is not a citation) - fix status styles (there were just small things wrong) - set padding for a paragraph that is neither citation nor status
wesleyboar
force-pushed
the
task/fp-1499-cms-pattern-library--fp-1726-publications-list
branch
from
240a076 to
3299c60
Compare
wesleyboar
force-pushed
the
task/fp-1499-cms-pattern-library--fp-1726-publications-list
branch
from
1060da1 to
6d945d3
Compare
…-pattern-library--fp-1726-publications-list
|
Retiring this repo in favor of https://github.com/TACC/tup-ui. |
No need for `-css` on build and test scripts.
|
The core-styles directory on https://github.com/TACC/tup-ui is frozen for now. Using this repo instead. |
wesleyboar
changed the base branch from
main
to
task/fp-1499-cms-pattern-library
…-pattern-library--fp-1726-publications-list
This reverts commit 1d5140c.
…-pattern-library--fp-1726-publications-list
wesleyboar
changed the title
…-pattern-library--fp-1726-publications-list
…-pattern-library--fp-1726-publications-list
|
The styles and may change after designers share feedback. |
|
Revisit better solution via FP-1770. |
wesleyboar
deleted the
task/fp-1499-cms-pattern-library--fp-1726-publications-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Better solution expected via FP-1770.
Overview
Create publication listing pattern and related patterns.
To Do
updates after sharing H.P. feedback with M.S.do not highlight titleprovide a manual design, because this is data-drivenconsider splitting publications styles into:"data-driven""manual-input"Related
required by Task/fp 1726 publications list Core-CMS#521Changes
.c-publication-preview.c-tag&.c-tag-listTesting
Core Styles
npm cinpm run build:cssnpm run startCore CMS
npm cinpm run buildnpm run start:css-demoUI
Local
Remote
(no deploy process available)