-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/FP-1014: Add Onboarding Admin link to User Nav Dropdown #388
Conversation
Codecov Report
@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 64.54% 64.54%
=======================================
Files 399 399
Lines 11999 11999
Branches 2060 2060
=======================================
Hits 7745 7745
Misses 3929 3929
Partials 325 325
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one change request for readability
Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com>
Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on code alone.
My local Portal dev is missing header (my fault), so I can't test rendering. But the code change is simple enough that I know this is right.
(Port change from PR #388 to nav_portal.html)
* Adding link to Onboarding Admin for Staff users only. * Updating menu item icon. * Update server/portal/templates/includes/nav_portal.html Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com> * Update server/portal/apps/workbench/urls.py Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com> Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com>
Overview:
Add link to Onboarding Admin in User Account Nav Dropdown
Related Jira tickets:
Summary of Changes:
Add link to Onboarding Admin in User Account Nav Dropdown for Staff users.
Testing Steps:
UI Photos:
Notes: