Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/FP-1014: Add Onboarding Admin link to User Nav Dropdown #388

Merged
merged 4 commits into from
Apr 28, 2021

Conversation

jmartinez-tacc
Copy link
Contributor

Overview:

Add link to Onboarding Admin in User Account Nav Dropdown

Related Jira tickets:

Summary of Changes:

Add link to Onboarding Admin in User Account Nav Dropdown for Staff users.

Testing Steps:

  1. Click over User Account Nav Dropdown
  2. Click on Onboarding Admin

UI Photos:

Screen Shot 2021-04-27 at 4 05 14 PM

Notes:

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #388 (1c6ab77) into main (2ef4070) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   64.54%   64.54%           
=======================================
  Files         399      399           
  Lines       11999    11999           
  Branches     2060     2060           
=======================================
  Hits         7745     7745           
  Misses       3929     3929           
  Partials      325      325           
Flag Coverage Δ
javascript 64.83% <ø> (ø)
unittests 64.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/portal/apps/workbench/urls.py 100.00% <ø> (ø)

@rstijerina rstijerina changed the title Task/fp 1014 new link task/FP-1014: Add Onboarding Admin link to User Nav Dropdown Apr 28, 2021
Copy link
Member

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one change request for readability

jmartinez-tacc and others added 2 commits April 28, 2021 14:08
Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com>
Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com>
Copy link
Member

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on code alone.

My local Portal dev is missing header (my fault), so I can't test rendering. But the code change is simple enough that I know this is right.

@rstijerina rstijerina merged commit c1f2858 into main Apr 28, 2021
@rstijerina rstijerina deleted the task/FP-1014-new-link branch April 28, 2021 21:52
wesleyboar added a commit that referenced this pull request Apr 28, 2021
wesleyboar pushed a commit that referenced this pull request Jan 7, 2022
* Adding link to Onboarding Admin for Staff users only.

* Updating menu item icon.

* Update server/portal/templates/includes/nav_portal.html

Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com>

* Update server/portal/apps/workbench/urls.py

Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com>

Co-authored-by: Sal Tijerina <r.sal.tijerina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants