Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore empty Container #897

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: restore empty Container #897

merged 1 commit into from
Nov 14, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Nov 14, 2024 •
edited
Loading

Overview

Restore ability to add a container that has no classes.

Caution

Crashes server. Requires b8ecc1c and 1aa1cd4.

Related

Changes

  • changed value in a setting
  • added values to a setting

Testing

  1. Verify Container select menu has changed (see settings diff).

UI

before
(e.g. d323b8b)		 after - select
(requires 1aa1cd4)		 after - render
(requires 1aa1cd4, b8ecc1c)
_before select render

@wesleyboar wesleyboar marked this pull request as ready for review November 14, 2024 00:31
@wesleyboar wesleyboar merged commit bb2af43 into main Nov 14, 2024
@wesleyboar wesleyboar deleted the fix/retore-empty-container branch November 14, 2024 00:31
wesleyboar added a commit that referenced this pull request Nov 14, 2024
@wesleyboar
fix: #897 typo
1aa1cd4
@wesleyboar wesleyboar mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar