Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CMD-162 error if no second breadcrumb #855

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

wesleyboar
Copy link
Member

Overview

Do not try to remove 2nd-level breadcrumb link if it does not exist.

Related

Changes

  • add checks for element existence before accessing

Testing

  1. Open a page whose only parent page is home.
    E.g. https://pprd.frontera-portal.tacc.utexas.edu/system/
  2. Verify no error in console.
    E.g. Cannot read properties of null (reading 'removeAttribute')

UI

Before After
CMD-162 before CMD-162 after

@wesleyboar wesleyboar merged commit b9213e9 into main Jul 25, 2024
@wesleyboar wesleyboar deleted the fix/CMD-162-error-if-no-second-breadcrumb branch July 25, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant